This repository has been archived by the owner on May 17, 2021. It is now read-only.
AlarmDecoder binding: port speed now configurable , new default of 115200 #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed inter-binding serial port conflicts, updated jar file has the fix. |
| @@ -9,6 +9,7 @@ Bundle-ManifestVersion: 2 | |||
| Bundle-License: http://www.eclipse.org/legal/epl-v10.html | |||
| Bundle-Description: This is the alarmdecoder backend for openHAB | |||
| Import-Package: gnu.io, | |||
| org.apache.commons.lang;version="2.6.0", | |||
|
thanks @berndpfrommer for this contribution which already lgtm. Please find some comments inline. Could you please also squash your commits into one, finally? |
…erial port conflicts with other bindings
berndpfrommer
force-pushed
the
alarmdecoder
branch
from
57e8873
to
30e9d3a
Compare
|
Changes from code review incorporated. |
|
you seem to have created the word "quick fix" ;-) Thanks @berndpfrommer! |
teichsta
added a commit
that referenced
this pull request
Nov 11, 2015
AlarmDecoder binding: port speed now configurable , new default of 115200
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users of the alarmdecoder binding to configure the port speed, and changes the default speed to 115200.
Related to this:
https://community.openhab.org/t/ad2usb-not-sending-messages-to-openhab/4086
For testing, here is a pre-build jar file that should work for OH 1.8 and 1.7:
https://drive.google.com/file/d/0B8OtzwATWQSWUUZfZEFyZUdoRlU/view?usp=sharing