Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Epson projector binding Improvements #5137

Merged
merged 1 commit into from Mar 12, 2017

Conversation

paulianttila
Copy link
Contributor

Introduced projector state cache, which will minimize projector state
queries.

Signed-off-by: Pauli Anttila pauli.anttila@gmail.com

Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one noted typo, this LGTM.

boolean needsUpdate = age >= projectorStateUpdateInterval;

if (needsUpdate) {
logger.debug("Quering projector '{}' state", deviceId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Querying"

Introduced projector state cache, which will minimize projector state
queries.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
@paulianttila
Copy link
Contributor Author

Thanks @9037568, typo fixed and commits squashed.

@9037568
Copy link
Contributor

9037568 commented Mar 12, 2017

Thanks for this, @paulianttila !

@9037568 9037568 added this to the 1.10.0 milestone Mar 12, 2017
@9037568 9037568 merged commit 20548c7 into openhab:master Mar 12, 2017
@paulianttila paulianttila deleted the epson-improvements branch May 9, 2018 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants