Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[weather] Added NPE safe-guard if HTTP request fails #5348

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@cweitkamp
Copy link
Contributor

commented Oct 31, 2017

Closes #5330

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Added NPE safe-guard if request fails
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@9037568
Copy link
Contributor

left a comment

LGTM.

@9037568 9037568 merged commit 4f922c5 into openhab:master Nov 6, 2017

1 check passed

Jenkins This pull request looks good
Details

@9037568 9037568 added this to the 1.11.0 milestone Nov 6, 2017

@cweitkamp cweitkamp deleted the cweitkamp:bugfix-5330 branch Nov 6, 2017

carabila added a commit to carabila/openhab1-addons that referenced this pull request Nov 12, 2017

Added NPE safe-guard if request fails (openhab#5348)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

9037568 added a commit that referenced this pull request Nov 24, 2017

[bticino] Added support to OpenWebNet password to bticino binding. (#…
…5352)

* Added support to OpenWebNet password.

* Changed logged messages from info to debug

* Pull request review changes.

* Licence headers updated with current year

* First scan delay reverted back to 60 secs.

* Changed logger of readMonitoring from error to warn

* README updated with binding configuration

* Update openhab_default.cfg

* Update openhab_default.cfg

Added Bticino gateway password configuration.

* Update MonitorSessionThread.java

Removed trailing apostrophe

* Update OpenWebNet.java

Removed trailing apostrophe

* Update MyHomeSocketFactory.java

Messages on thrown exceptions

* Added NPE safe-guard if request fails (#5348)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* [epson] Fixed logging (#5339)

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>

* [pushbullet] initial action contribution (#5225)

* [pushbullet] initial action contribution

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] 1.10 is released, switch to 1.11.0

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] Eclipse requires classpath entries to be present, add the dummy file as everyone else does

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] fix @SInCE annotations and copyright years

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] applied standard formatting rules

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] Fix typo in example configuration file

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] Implemented review comments

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] Oops, forgot to actually declare that we use gson annotations

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] Removed TODO reminders from the README.md

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* [pushbullet] Removed private email address from examples

Signed-off-by: Hakan Tandogan <hakan@tandogan.com>

* Changed default of OPEN password to 12345

To match the gateways default OPEN password.

* Update openhab_default.cfg

Changed default of OPEN password to 12345. 
To match the gateways default password.

* Update openhab_default.cfg

Fix on password description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.