Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.bash and documentation #856

Closed
holgerfriedrich opened this issue Apr 26, 2020 · 10 comments · Fixed by #938
Closed

Update test.bash and documentation #856

holgerfriedrich opened this issue Apr 26, 2020 · 10 comments · Fixed by #938
Labels
bug Something isn't working documentation Relating to documentation

Comments

@holgerfriedrich
Copy link
Member

holgerfriedrich commented Apr 26, 2020

Test.bash is outdated.

  • In parametrize for production, test and verbose debugging install runs #683 Dockerfile has been renamed. We need to update testing related scripts
    and CONTRIBUTING.md, README.md docker build -f Dockerfile.openhabian-x86 ... OR decide to rename Dockerfile.openhabian-x86 to Dockerfile (affects .travis.yml)
  • Shellcheck test is incomplete (build.bash is not shellchecked, see .travis.yml for reference)
  • Feature request: add calling bats test w/o Docker
  • Add something about test.bash to documentation
@holgerfriedrich holgerfriedrich added enhancement New feature or request bug Something isn't working documentation Relating to documentation and removed enhancement New feature or request labels Apr 26, 2020
@mstormi
Copy link
Contributor

mstormi commented Apr 26, 2020

Did you try build.bash after #684 meanwhile ?
Latest is shellchecked BTW.

@holgerfriedrich
Copy link
Member Author

@mstormi I think you got me wrong, test.bash does not do it, so pre-commit testing might overlook it

@mstormi
Copy link
Contributor

mstormi commented May 31, 2020

from .travis.yml: build.bash is shellchecked
- shellcheck -x -s bash openhabian-setup.sh functions/.bash build-image/.bash build.bash && echo "shellcheck - OK"

@mstormi
Copy link
Contributor

mstormi commented May 31, 2020

btw does building an image work ? Would like to provide a new one to contain the 02/2020 update from raspberry.org plus our pre-fetched java.

@holgerfriedrich
Copy link
Member Author

@mstormi it should. I started using the image 1.6 milestone to collect what is essential from my point of view.

@mstormi
Copy link
Contributor

mstormi commented May 31, 2020

haeh? I didn't catch that.
Won't wait for 1.6, that would be in time for bullseye upgrade.

@holgerfriedrich
Copy link
Member Author

For me 1.6 is just next image milestone. I did remove "bullseye" from title.... bullseye is years away from now

@mstormi
Copy link
Contributor

mstormi commented May 31, 2020

Well usually we only ever released images together with debian upgrades so I was thinking to call the next 1.5.1 then 1.6 would be for bullseye.
Then again, the Java upgrade also is pretty substantial. We can discuss for sure. Or roll dices ;-)

@mstormi
Copy link
Contributor

mstormi commented Jun 16, 2020

@ecdye did your recent update on test.bash affect or fix this ?

@ecdye
Copy link
Contributor

ecdye commented Jun 16, 2020

It should have, yes (once #938 is merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Relating to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants