Set the default link key #257
Conversation
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
org.openhab.binding.zigbee/README.md
Outdated
|
|
||
| The key is defined as 16 hexadecimal values. If not defined, this will default to the well known ZigBee HA link key. | ||
|
|
||
| If defined with the work ```INSTALLCODE:``` before the key, then this will create a link key from an install code which may be shorter than 16 bytes. |
There was a problem hiding this comment.
Could these be typos?
with the work->with the wordbefore the key, then this will->before the key, this will
| try { | ||
| logger.debug("Link Key String {}", linkKeyString); | ||
| linkKey = new ZigBeeKey(linkKeyString); | ||
| } catch (IllegalArgumentException e) { |
There was a problem hiding this comment.
Minor suggestion: Add a log statement within the catch block, so that it gets visible in the log that (and why) the system falls back to the well-known key.
That the system fell back to the well-known key is also visible (though somewhat implicit) from the log statement with the final link key array, the additional log statement would make this more explicit.
| linkKey = new ZigBeeKey(linkKeyString); | ||
| } catch (IllegalArgumentException e) { | ||
| linkKey = KEY_ZIGBEE_ALLIANCE_O9; | ||
| logger.debug("Link Key String has invalid format. Revert to default key.", linkKeyString); |
There was a problem hiding this comment.
I believe the {} placeholder for the linkKeyString parameter is missing in the log string.
There was a problem hiding this comment.
Thanks - cut and paste error ;)
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
|
Thanks for the update, looks good to me. |
Recent Ember dongle driver does not set the default link key, so at the moment, the link key won't be set during initialisation. Other dongles should also be updated in future so this ensures the standard link key is set.
Signed-off-by: Chris Jackson chris@cd-jackson.com