Make interface WarningTypeCommandDescriptionProvider and related enums API #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this interface is not exported. It should be imported, because it is intended to be implemented by providers in other bundles. Signed-off-by: Henning Sudbrock <henning.sudbrock@telekom.de>
The reason for making those API is to allow implementors of WarningTypeCommandDescriptionProviders to use them to construct warning types in a type-safe way. Signed-off-by: Henning Sudbrock <henning.sudbrock@telekom.de>
hsudbrock
changed the title
|
Thanks Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the interface
WarningTypeCommandDescriptionProvideris not exported. The interface should, however, be exported, because it is intended to be implemented by providers that might be in other bundles.For this reason, I have moved the interface to the subpackage
warningdeviceof the non-internalconverterpackage. Likewise, I have added related enums into the exported subpackage, as they can be used to create warning type command options in a type-safe way.