Use OHC serial transport #513
Conversation
Signed-off-by: Wouter Born <github@maindrain.net>
wborn
force-pushed
the
use-ohc-serial-transport
branch
from
56f45a9
to
c539277
Compare
There was a problem hiding this comment.
lgtm, it is due since a long time to do this adaption.
@cdjackson You commented on openhab/openhab-core#1176 (comment), but I am not sure, what prevents us from merging this - after all, this change helps decoupling the used serial library from the binding, so that solutions are more flexible to make the binding work with the chosen serial lib.
|
Yes, this does help to decouple the libraries, but at the moment this is not necessary and will require considerable work that I haven’t planned for. If we merge this, it’s just another thing that I need to do that will take my time and I’d therefore prefer not to do this now.
… On 8 Nov 2019, at 01:34, Kai Kreuzer ***@***.***> wrote:
@kaikreuzer approved this pull request.
lgtm, it is due since a long time to do this adaption.
@cdjackson <https://github.com/cdjackson> You commented on openhab/openhab-core#1176 (comment) <openhab/openhab-core#1176 (comment)>, but I am not sure, what prevents us from merging this - after all, this change helps decoupling the used serial library from the binding, so that solutions are more flexible to make the binding work with the chosen serial lib.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#513?email_source=notifications&email_token=AAH6IQYWELSMAHCOOVGF6EDQSQ7TBA5CNFSM4JILLXXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKXTWNA#pullrequestreview-313473844>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6IQ7JKVVVK6HKQAWDX4TQSQ7TBANCNFSM4JILLXXA>.
|
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
I will close this PR since I don't have time to babysit it and fix merge conflicts. |
|
That's a pity, because I would have thought that we should now merge it for 3.x :-/ |
|
Yes but I don't get the impression there will be much progress in @cdjackson s repos for the foreseeable future. |
I'm not sure why you think that? I would suggest to leave this open. |
In order to merge it? |
Yes - I want to do a bunch of updates to get all the latest stuff merged over Christmas. This also includes updating to the latest ZigBee library (there is another PR open here for that) but I didn't want to merge all these changes prior to 2.5. |
|
You can reopen it and merge it if you want. But make sure to do it before I cleanup stale branches in my fork. |
|
Ok, but I won't be able to do anything for another week or so. As I said - this is a job for Christmas to get this and a number of other updates merged now that 2.5 is released. |
|
OK great! The allow edits from maintainers checkbox is enabled. So it should be possible for them to fix any merge conflicts. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
Thanks for merging it @cdjackson! |
|
No probs - thanks for creating it :)
… On 27 Dec 2019, at 18:04, Wouter Born ***@***.***> wrote:
Thanks for merging it @cdjackson <https://github.com/cdjackson>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#513?email_source=notifications&email_token=AAH6IQ53W5PFYQRDKDV57VTQ2Y7S7A5CNFSM4JILLXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXRT7A#issuecomment-569317884>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6IQ5QPQ5JDRYTRNWNJBLQ2Y7S7ANCNFSM4JILLXXA>.
|
Switches the binding to use the OHC serial transport instead of gnu.io directly.
Related to openhab/openhab-core#1176