Update ZSmart Systems libraries to 1.3.0 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
kaikreuzer
requested changes
Jan 19, 2020
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
|
Yep - well spotted. Not sure how that crept in.
Thanks.
… On 19 Jan 2020, at 14:49, Kai Kreuzer ***@***.***> wrote:
@kaikreuzer requested changes on this pull request.
In pom.xml <#553 (comment)>:
> @@ -216,13 +216,6 @@
</executions>
</plugin>
</plugins>
- <extensions>
This looks like an accidential removal?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#553?email_source=notifications&email_token=AAH6IQ4GHV7TRYVV4QC53JTQ6RSAZA5CNFSM4KIZSS72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSIGF3A#pullrequestreview-345006828>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6IQ5OPPSZV4WNJK46ZZLQ6RSAZANCNFSM4KIZSS7Q>.
|
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/cannot-add-immax-neo-smart-led-stripe-with-zigbee-binding/90691/3 |
|
PR build failed with a compilation failure. |
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
|
I merged #548 into this PR after doing my tests, and it didn't merge the imports correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Jackson chris@cd-jackson.com