Alarm and multilevel sensor report updates

[cdjackson]

@maxberger Please give this a go. It's nearly 12 months old and all I've done it try to resolve the merge issues without any real testing (let's see if the tests pass even!).

Let me know how it looks and if there are any issues I'll have a look.

Signed-off-by: Chris Jackson chris@cd-jackson.com

[maxberger]

I can now verify:
a) The code compiles, passes the tests, and has no obvious deficiencies
b) It now tries to send a REPORT message, as required (see log below)

I will now set this thermostat into external mode again and will see by tomorrow if it behaves correctly.

Thanks so far!

23:32:56.190 [INFO ] [smarthome.event.ItemCommandEvent ] - Item 'zwave_device_710d4836_node12_sensor_report' received command 21
23:32:56.210 [INFO ] [arthome.event.ItemStatePredictedEvent] - zwave_device_710d4836_node12_sensor_report predicted to become 21
23:32:56.215 [DEBUG] [nding.zwave.handler.ZWaveThingHandler] - NODE 12: Command received zwave:device:710d4836:node12:sensor_report --> 21 [DecimalType]
23:32:56.255 [DEBUG] [ass.ZWaveMultiLevelSensorCommandClass] - NODE 12: Creating new message for command SENSOR_MULTILEVEL_REPORT, Set TEMPERATURE to 21 with scale 0
23:32:56.241 [INFO ] [smarthome.event.RuleStatusInfoEvent ] - 47fc2df1-3eda-430b-9ddd-9603ad0c9754 updated: RUNNING
23:32:56.263 [DEBUG] [ing.zwave.internal.protocol.ZWaveNode] - NODE 12: SECURITY NOT required on COMMAND_CLASS_SENSOR_MULTILEVEL
23:32:56.274 [DEBUG] [ing.zwave.internal.protocol.ZWaveNode] - NODE 12: Command Class COMMAND_CLASS_SENSOR_MULTILEVEL is NOT required to be secured
23:32:56.270 [INFO ] [smarthome.event.ItemStateChangedEvent] - zwave_device_710d4836_node12_sensor_report changed from 21.22 to 21
23:32:56.278 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - NODE 12: Bump transaction 224 priority from Set to Immediate
23:32:56.287 [INFO ] [smarthome.event.RuleStatusInfoEvent ] - 47fc2df1-3eda-430b-9ddd-9603ad0c9754 updated: IDLE
23:32:56.293 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - NODE 12: Adding to device queue
23:32:56.305 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - NODE 12: Added 224 to queue - size 17
23:32:56.308 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - Transaction SendNextMessage 1 out at start. Holdoff false.
23:32:56.314 [DEBUG] [nding.zwave.handler.ZWaveThingHandler] - NODE 12: Polling intialised at 86400 seconds - start in 1500 milliseconds.
23:32:57.813 [DEBUG] [nding.zwave.handler.ZWaveThingHandler] - NODE 12: Polling...

[cdjackson]

Great - thanks for the confirmation so far.

…

On 24 Oct 2018, at 22:34, maxberger ***@***.***> wrote: I can now verify: a) The code compiles, passes the tests, and has no obvious deficiencies b) It now tries to send a REPORT message, as required (see log below) I will now set this thermostat into external mode again and will see by tomorrow if it behaves correctly. Thanks so far! 23:32:56.190 [INFO ] [smarthome.event.ItemCommandEvent ] - Item 'zwave_device_710d4836_node12_sensor_report' received command 21 23:32:56.210 [INFO ] [arthome.event.ItemStatePredictedEvent] - zwave_device_710d4836_node12_sensor_report predicted to become 21 23:32:56.215 [DEBUG] [nding.zwave.handler.ZWaveThingHandler] - NODE 12: Command received zwave:device:710d4836:node12:sensor_report --> 21 [DecimalType] 23:32:56.255 [DEBUG] [ass.ZWaveMultiLevelSensorCommandClass] - NODE 12: Creating new message for command SENSOR_MULTILEVEL_REPORT, Set TEMPERATURE to 21 with scale 0 23:32:56.241 [INFO ] [smarthome.event.RuleStatusInfoEvent ] - 47fc2df1-3eda-430b-9ddd-9603ad0c9754 updated: RUNNING 23:32:56.263 [DEBUG] [ing.zwave.internal.protocol.ZWaveNode] - NODE 12: SECURITY NOT required on COMMAND_CLASS_SENSOR_MULTILEVEL 23:32:56.274 [DEBUG] [ing.zwave.internal.protocol.ZWaveNode] - NODE 12: Command Class COMMAND_CLASS_SENSOR_MULTILEVEL is NOT required to be secured 23:32:56.270 [INFO ] [smarthome.event.ItemStateChangedEvent] - zwave_device_710d4836_node12_sensor_report changed from 21.22 to 21 23:32:56.278 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - NODE 12: Bump transaction 224 priority from Set to Immediate 23:32:56.287 [INFO ] [smarthome.event.RuleStatusInfoEvent ] - 47fc2df1-3eda-430b-9ddd-9603ad0c9754 updated: IDLE 23:32:56.293 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - NODE 12: Adding to device queue 23:32:56.305 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - NODE 12: Added 224 to queue - size 17 23:32:56.308 [DEBUG] [rnal.protocol.ZWaveTransactionManager] - Transaction SendNextMessage 1 out at start. Holdoff false. 23:32:56.314 [DEBUG] [nding.zwave.handler.ZWaveThingHandler] - NODE 12: Polling intialised at 86400 seconds - start in 1500 milliseconds. 23:32:57.813 [DEBUG] [nding.zwave.handler.ZWaveThingHandler] - NODE 12: Polling... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1042 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_kQ88OU9sEf0V2AOtC6pe9HaHV04JOks5uoNzRgaJpZM4X43V->.

[maxberger]

Update: my thermostat has been behaving as it should for the past 24hrs, please merge!

[cdjackson]

Great - thanks for testing.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/eurotronic-spirit-z-wave-plus-external-temperatures/55645/5