Skip to content
This repository has been archived by the owner on May 23, 2019. It is now read-only.

Filterable dropdown #72

Closed
wants to merge 21 commits into from
Closed

Filterable dropdown #72

wants to merge 21 commits into from

Conversation

kubawolanin
Copy link
Contributor

@kubawolanin kubawolanin commented Nov 27, 2016

Hello!

  • Added RESTConfig value for pointing into different openHAB instance (it was useful for testing).
  • Easier way to select openHAB Item from the dropdown - now you can filter it and search by name and/or label
  • Added angular ui-select and ngSanitize
  • Some minor cleanups

Resolves #82 and #27

Cheers!

@ghys
Copy link
Member

ghys commented Dec 3, 2016

Cool - I don't use the old 1.x weather binding (I use the new 2.0 yahooweather binding even though it's more limited, it only has 3 channels) so I'll need some time to build a test environment to review it thoroughly, probably some time next week. I expect others will need help configuring this as well.

To be completely honest, my view has not changed: those kinds of special-purpose widgets could benefit from being implemented and distributed as custom widgets rather than adding weight to the main app, especially when they require some prerequisite item/binding configuration; this is what the feature is for. And it also allows others to easily make changes to their liking. The Climacons could be bundled separately in a regular openHAB iconset (the iconset framework even knows how to retrieve the right icon depending on a provided state - i.e. /icon/climacons?format=svg&state=few-showers would retrieve the appropriate svg for the "few-showers" state). Now I understand you would lose the animations since there's a (quite huge) separate SCSS file for that.

That being said, don't worry, I certainly plan it for inclusion since you invested time and there seems to be demand for it. 😉

A few comments on the PR itself: to speed up the review work, I would appreciate it if you could create a separate branch for each feature instead of submitting several mashed up in your main tree. There are even old commits in there that are already merged. Check the other pull requests for examples (I know there are a few exceptions to this rule, and I'm flexible about this since it's a hobby project and all investing our spare time, but most of the other pull requests are focused on a specific area). If a PR needs another one to work I can merge them in the right order. Also it's better to use the --rebase option when updating your local branch to avoid merge commits.

Thanks for your understanding and keep it up! Stay tuned for the review. 😄

@kubawolanin kubawolanin changed the title Weather widget + filterable dropdown Filterable dropdown Dec 11, 2016
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
… edit button

Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Signed-off-by: Kuba Wolanin <hi@kubawolanin.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants