Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature missing automation/voice add-ons #291

Merged
merged 1 commit into from
May 16, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented May 16, 2021

These types don't have an all button because there aren't many.
If the missing add-ons are featured, they can be more easily discovered.


There's also openhab/openhab-docs#1574 to add images for these add-ons.

These types don't have an all button because there aren't many.
If the missing add-ons are featured, they can be more easily discovered.

Signed-off-by: Wouter Born <github@maindrain.net>
@ghys
Copy link
Member

ghys commented May 16, 2021

I noticed that yesterday ;)
And found out this is one of the little flaws of wanting to build both openhab.org and next.openhab.org off the same main branch... Currently the deploy previews are made only for openhab.org (for events, blog posts etc) but since it succeeded and simply ignores the add-ons it doesn't find I guess we're good!
Thanks!

@ghys ghys merged commit 4566ce4 into openhab:main May 16, 2021
@wborn
Copy link
Member Author

wborn commented May 16, 2021

Yes it seems to work well with both versions! 🙂

@wborn wborn deleted the automation-voice-featured branch May 16, 2021 10:30
@ghys
Copy link
Member

ghys commented May 16, 2021

Feel free to suggest additional "featured" bindings, the list is a little outdated. I'd remove "nest" because of the API shutdown, and add maybe "http", perhaps others ("remoteopenhab", 'ipcamera"...? Too bad they don't have logos).

I merged openhab/openhab-docs#1574 and cherry-picked it to stable so the next builds will have the logos.

@wborn
Copy link
Member Author

wborn commented May 17, 2021

I'd remove "nest" because of the API shutdown, and add maybe "http", perhaps others ("remoteopenhab", 'ipcamera"...? Too bad they don't have logos).

That's OK with me. I think the Nest Binding is feature-worthy again when my PR for adding support for the new API is merged. 😉

so the next builds will have the logos.

It seems that all add-ons are considered to provide "supported things" on the main page. The sorting looks a bit odd now the automation add-on images show up first:

supported-things

ghys added a commit that referenced this pull request May 17, 2021
Addresses #291 (comment)

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit that referenced this pull request May 18, 2021
Addresses #291 (comment)

Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants