Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AMD 17h (Ryzen) Support #970

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Kraust
Copy link

@Kraust Kraust commented Apr 23, 2017

AX370

I have not figured out how to get Ryzen's Temperature / Vcore sensors yet as AMD hasn't released their guide on how to do this. Also, some of the scalars for the voltages (e.g. +12v) I reverse calculated based on HWiNFO's data.

@DarthDestroyer
Copy link
Contributor

Good Job!

@segfir
Copy link

segfir commented Apr 23, 2017

Can confirm these changes work on my Gigabyte AB350 Gaming 3 since it uses the same chip. If you'd like to add support for my motherboard, its string id is "AB350-Gaming 3-CF". Otherwise, I'll create a pull request once these changes are in.

@lucascosti
Copy link

Great job, this looks to be working with my Z270X-Gaming K5 board too :)

@valpackett
Copy link

This "Ryzen support" (same as #962) does not read the actual frequency, it reads the stock frequency :( It's always 3 GHz on my 1700, when it's actually running at 3.92

@berendiwema
Copy link

Hello @Kraust ,

Do you have the compiled DLL's by any chance? I'm hoping to drop them in with the Sidebar Gadget app and get CPU temps :)

With kind regards,
Berend

@Hubfront
Copy link

Looks interesting. Where can i download the compiled binary?

@DarthDestroyer
Copy link
Contributor

Only a little advice to anyone who asks for compiled software:

Only download from trusted sources!
Self compiling is so hard as writing a Word Document... ;)

@bigpod98
Copy link

Yea specaily c#

@Kraust
Copy link
Author

Kraust commented Jul 31, 2017

Sorry I tried to do some updating of VS yesterday, and I was getting some very weird errors. My Windows install must have gotten borked somehow and I don't have access to VS right now.

@Hubfront
Copy link

"Self compiling is so hard as writing a Word Document... ;)"

Probably not for me. ;-)

I installed visual studio community from
https://www.visualstudio.com/de/thank-you-downloading-visual-studio/?sku=Community&rel=15#
but unfortunately i did not manage to build an exe yet from the project file OpenHardwareMonitor.csproj .

Does a help page exist as starting point for do it yourself compiling?

@DarthDestroyer
Copy link
Contributor

#995 was the last issue i had explained it further... hope that helps!

@Hubfront
Copy link

Hi Kraust, thank you for your reply. I will try do compile it by myself.

@Hubfront
Copy link

"#995 was the last issue i had explained it further... hope that helps!"

Thank you, ill try !

@berendiwema
Copy link

@DarthDestroyer cheers, compiled the DLL, works as expected.

@DarthDestroyer
Copy link
Contributor

perfect! that is the best way and im happy that i could have helped!

- Added Support for Gigabyte AX370 Gaming 5 and AB350 Gaming 3
- Other people who want their Motherboard added (That supports the IT8686E LPCIO please submit a ticket with the Mainboard Tab from CPUZ.
@Kraust
Copy link
Author

Kraust commented Nov 13, 2017

Updated 2017-11-12:

I added additional support for Ryzen temperature monitoring and several new chipsets. I will go through the comments now and see if there's anything else I can add as well.

I also want to tackle the "RX 400 and RX 500 series GPUs do not report Voltage Properly" issue, but I know there were recent driver changes on AMD's side which might impact this.

image

@Kraust Kraust changed the title Added support for Gigabyte AX370 Gaming K7 (Added Partial-Ryzen Support Too) Added AMD 17h (Ryzen) Support Nov 13, 2017
@valpackett
Copy link

The 20 degree offset is only on chips with XFR (the X models), don't add it for everyone

@xdmtk
Copy link

xdmtk commented Aug 23, 2018

@xSPARExSTEWx Interesting you mention this. I own a Ryzen 7 2700X, and during testing, I was comparing temps to CPUID's HW Monitor. The temps I was getting were way higher than what HW Monitor was reading. Strangely enough they were just about near the Fahrenheit temps, (about -5 under), so I figured it needed to be converted to Celsius?

I haven't done the research on it (datasheet) yet but for me, a 20 degree offset still puts me at a ridiculously inaccurate reading.

I know this is somewhat old, but can anyone else confirm the 20 degree offset being the case with Ryzen 7 X models?

@t0mb3r
Copy link

t0mb3r commented Aug 25, 2018

Hello, Can someone upload the compiled dll with the ryzen support?

@TwistedMetal85
Copy link

I don't remember where i download this version but it's work great for my Ryzen 1700x
OpenHardwareMonitor RyZen.zip

@t0mb3r
Copy link

t0mb3r commented Aug 27, 2018

ok, so I have compiled the software and it works with some issues, for some reason the CPU frequency isnt shown correctly, it shows the stock clock, not the actual clock, and the CPU temperature has an odd 49 degrees offset.
image

@t0mb3r
Copy link

t0mb3r commented Aug 27, 2018

@TwistedMetal85 thank you but I need this version because I use it with other software

@t0mb3r
Copy link

t0mb3r commented Aug 27, 2018

@Kraust I have done some progress, I figured that the temperature is really an odd offset and I was able to display it correctly, now the CPU CLOCK is not displayed correctly, is there a workaround? My motherboard is AB350M-D3H, I have added it.

@TwistedMetal85
Copy link

@t0mb3r is a 0.8.0.2 version but someone fix it.
ohm ryzen

Have you tried my .zip file?

@t0mb3r
Copy link

t0mb3r commented Aug 28, 2018

Yes, the one you are using is based on the librehardwaremonitor, for some reason it doesnt work with what Im using, but somehow I have everything running now, there is no offset with the temperature but the cpu frequency only shows correctly if the cpu is overclocked though the bios. Any ways, everything is working in most of the part. Thank you and it would be awesome to continue with the support.

@PatrickSchmidtSE
Copy link

I wanted to ask if there is any update in sight? I know you can use the librehardwaremon, but it is not matching our target .net framework .

I know i can manually compile the pull requests but as this issue is now older than one year, i am wondering if there will be updates at all to this project?

@DarthDestroyer
Copy link
Contributor

That is a question only @moellerm could answer!

I am sure, that there will be a update but as i said, only he could give an eta!

A big help would be, that all Pull Request Tester give Feedback! As for sure, no one can get all kind of Hardware and its combinations... That would help a lot to get everything accepted!

@PatrickSchmidtSE
Copy link

Thanks for the fast answer! I will make sure that we get this pull request tested. I updated my code with these changes and try to get feedback within the next weeks and will report back!

@mcarbonneaux
Copy link

mcarbonneaux commented May 1, 2019

i've compiled and tested this patch and it's work find with my ryzen 5 2600 + gigabyte b450 aorus!
can you comit this pull request in master branch ?

@PatrickSchmidtSE
Copy link

i can also say that this patch is working! So it should be forked into the master branch :)

@MasonLyons
Copy link

MasonLyons commented May 3, 2019

Just tested and it's reading 90C on my 2700x using an ASUS PRIME X470-PRO and Ryzen Master is reporting 31C using the latest release from here https://github.com/Kraust/openhardwaremonitor/releases 0.8.1

@MasonLyons
Copy link

I've done some more testing and to get the right value as reported by Ryzen master I have to do this
(sensor.value * 10) - 273.15) / 10

@PatrickSchmidtSE
Copy link

Thats some good input! Was this just testing with the value or did you find any sort of documentation where this formula is based off?

@MasonLyons
Copy link

It was after some trial and error when trying to convert the numbers between different units. It was clear the number reported was wrong so I just started messing around with it. I vaguely remember seeing something related to a multiplication of 10 in some other temperature program but I'm not confident where or if it was related. We're using it as part of an automation framework for reviews so until the issue gets fixed I'm manually applying this fix for AMD. The was specifically tested on a Z399 AORUS XTREME-CF with a Threadripper 1950x

@DarthDestroyer
Copy link
Contributor

it is not so far away for a sensor to include some kind of "zero"! At this point it is the absolute zero in Celsius or 0K.

But if you overlook the math, it could be easier and shorter ;-)

@PatrickSchmidtSE
Copy link

Any update on this?
I have some " AMD Ryzen 5 2400G CPU/APU" which seems to be not working with this commits! AMD Ryzen seems to be getting out of hands with all those new weird stuff.

@aquacomputer
Copy link

can you try out the latest version: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor

@PatrickSchmidtSE
Copy link

I will try it out if i get access to those machines again :)

@PatrickSchmidtSE
Copy link

Yes i tested it with one machine and can confirm it!!
Any chance this will get included in OHM? Otherwise i need to do a analysis myself what part changed in Libre so i can do the changes in my local OHM source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet