Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Growl alert background color #485

Closed
wants to merge 4 commits into from
Closed

Growl alert background color #485

wants to merge 4 commits into from

Conversation

fredkingham
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 27, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 71.531% when pulling 772552a on growl-alert-background-color into 040b482 on v0.3.6.

@fredkingham
Copy link
Contributor Author

screen shot 2018-09-27 at 16 20 45

@davidmiller
Copy link
Member

I think this needs merge conflicts resolving now...
If we're going to do it, can we not find a css class for the tick and make it white?

@fredkingham
Copy link
Contributor Author

@davidmiller its not a css class its an image 😞 I can try to colour it but it'll be awkward...

@fredkingham
Copy link
Contributor Author

The previous behaviour is preferred.

@fredkingham fredkingham closed this Oct 2, 2018
@davidmiller
Copy link
Member

screen shot 2018-10-02 at 15 58 44
Honestly, I prefer the green on green to green on blue if we can't easily change the image....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmiller davidmiller Awaiting requested review from davidmiller

Assignees

@fredkingham fredkingham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredkingham @coveralls @davidmiller