Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

690 moves to opal 13 django 2 #694

Merged
merged 9 commits into from
Feb 13, 2019
Merged

690 moves to opal 13 django 2 #694

merged 9 commits into from
Feb 13, 2019

Conversation

fredkingham
Copy link
Contributor

Note the decimal place/float

@coveralls
Copy link

coveralls commented Feb 12, 2019 •
edited

Coverage Status

Coverage increased (+0.007%) to 77.954% when pulling b63deb7 on 690-moves-to-opal-13-django-2 into 8531baf on v0.7.

davidmiller
davidmiller reviewed Feb 13, 2019
View reviewed changes
elcid/api.py Outdated
@@ -1,5 +1,6 @@
import datetime
import re
import decimal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this import ?
Shouldn't some kind of flake8 check catch that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fredkingham fredkingham merged commit 8d6d1b5 into v0.7 Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmiller davidmiller davidmiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredkingham @coveralls @davidmiller