Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored lab tests #716

Merged
merged 21 commits into from
Mar 27, 2019
Merged

Refactored lab tests #716

merged 21 commits into from
Mar 27, 2019

Conversation

fredkingham
Copy link
Contributor

No description provided.

@fredkingham
A refactored api that can easily be switched in and out for the front…
901b706 
… end apis
@fredkingham
adds a way of creating a lab test from an api dict
0c36a3e
@fredkingham
corrects comment on the dev api, to more accurately describe its retu…
e1ae3fe 
…rn value
@fredkingham
refactors in the models, adds created/updated timestamps, fixes a bug…
1df552c 
… where sites wasn't being saved
@fredkingham
changes the intrahospital api to update the new lab tests models
d67dd94
@fredkingham
we stop using the api to convert tests and add a management command
4e46160
@fredkingham
add in a missing timezone dependency
280f0f3
@fredkingham
bug fixes to serialisation and deserialisation of the new lab tests f…
f278fc9 
…ormat
@fredkingham
adds an as_view method to the new labtests to match the api of the ol…
fd34999 
…d lab tests
@fredkingham
changes the update lab tests in the intrahospital api to create the p…
86ce464 
…lugin.labtest lab tests as well as the old lab tests
@fredkingham
fix the upstream api for the new and old apis
046035e
@fredkingham
amend the api of the new lab tests to be the same as the old, even th…
ae71800 
…ough its not pretty
@fredkingham
lab test unit test fixes
dabaaa7
@fredkingham
Simplifies the get_or_create_lab_test method to use djangos get_or_cr…
2ae24f7 
…eate
@fredkingham
Updates the lab test serialisation to use the deserialiser from opal
66358dc
@fredkingham
changes the date serialisation to use the same method as in opal, add…
4669a8f 
…s a unit test for the to dict method
@coveralls
Copy link

coveralls commented Mar 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 77.927% when pulling e6cf1e4 on refactored-lab-tests into fe28d26 on v0.9.

davidmiller
davidmiller reviewed Mar 22, 2019
View reviewed changes
plugins/labtests/models.py
"lab_number",
]
for f in fields:
setattr(s, f, extras.get(f, None))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd swear a lot if this line ever turned up in a stacktrace :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved on 83b691d

davidmiller
davidmiller reviewed Mar 22, 2019
View reviewed changes
elcid/api.py Outdated Show resolved Hide resolved
@fredkingham
Copy link
Contributor Author

@davidmiller I think these are all resolved. Thoughts?

@davidmiller davidmiller merged commit 90d2f68 into v0.9 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmiller davidmiller davidmiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredkingham @coveralls @davidmiller