reorders lab tests ordering #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he end and stop waisting cycles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this does...
Expose 7 tests per row, use limit on the client side, this is not perfect... but meant if we had 1-7th of October we were only showing 1-5 when we reversed the date order. This fixes that.
Fixes lab test order, lab tests are ordered by most recent observation then by lab test name. So it fixes that.
Fixes a bug in the existing implementation. There was an indentation bug, sorting was happening at the end of every single loop. This changes it sorting just happens once at the end.