Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change in interaction #888

Closed
wants to merge 6 commits into from
Closed

Conversation

fredkingham
Copy link
Contributor

It was the case that if you had micro input that did was not ICU_ROUND but became ICU_ROUND error that it would throw an error because the editing dict was not correctly populated.

This changes it, now from the apis perspective there is always a micro_input_icu_round_relation.

From the database's perspective this is not the case and it is deleted if the reason for interaction changes. This means that we definitely reset the micro icu round if the icu round has changed.

@fredkingham fredkingham changed the base branch from v0.33 to v0.32 April 7, 2020 16:29
@fredkingham fredkingham closed this Apr 7, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 79.094% when pulling 952cbce on fix-change-in-interaction into e3b93f0 on v0.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants