Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is no micro input icu round relation serialize an empty micr… #889

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

fredkingham
Copy link
Contributor

…o icu relation so that it can be updated by the client if need be.

It was the case that if you had micro input that did was not ICU_ROUND but became ICU_ROUND error that it would throw an error because the editing dict was not correctly populated.

This changes it, now from the apis perspective there is always a micro_input_icu_round_relation.

From the database's perspective this is not the case and it is deleted if the reason for interaction changes. This means that we definitely reset the micro icu round if the icu round has changed.

…o icu relation so that it can be updated by the client if need be.
@fredkingham fredkingham changed the base branch from v0.33 to v0.32 April 7, 2020 16:33
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 79.094% when pulling c38d2e5 on fix-change-in-reason-for-interaction into e3b93f0 on v0.32.

@davidmiller davidmiller merged commit 816f08e into v0.32 Apr 8, 2020
@davidmiller davidmiller deleted the fix-change-in-reason-for-interaction branch April 8, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants