APIs should 404 rather than 500 when they can't find the thing.

openhealthcare · Feb 25, 2016 · 1b6db23 · 1b6db23
1 parent 312366a
commit 1b6db23
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/opal/core/api.py b/opal/core/api.py
@@ -380,7 +380,10 @@ class PatientListViewSet(viewsets.ViewSet):
     base_name = 'patientlist'
 
     def retrieve(self, request, pk=None):
-        patientlist = PatientList.get(pk)()
+        try:
+            patientlist = PatientList.get(pk)()
+        except ValueError:
+            return Response({'error': 'List does not exist'}, status=status.HTTP_404_NOT_FOUND)
         return _build_json_response(patientlist.to_dict(request.user))
 
 

diff --git a/opal/tests/test_api.py b/opal/tests/test_api.py
@@ -681,3 +681,7 @@ def test_retrieve_episodes(self, patient_list):
         expected = _build_json_response({}).content
         response = api.PatientListViewSet().retrieve(self.mock_request, pk='mylist').content
         self.assertEqual(expected, response)
+
+    def test_retrieve_episodes_not_found(self):
+        response = api.PatientListViewSet().retrieve(self.mock_request, pk='not a real list at all')
+        self.assertEqual(404, response.status_code)