Skip to content

Commit

Permalink
making an array.length if clause in the hospital number controller sl…
Browse files Browse the repository at this point in the history
…ightly more succinct
  • Loading branch information
fredkingham committed Oct 4, 2018
1 parent 1a2fba8 commit 65824bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion opal/static/js/opal/controllers/hospital_number.js
Expand Up @@ -72,7 +72,7 @@ angular.module('opal.controllers').controller(
_.values(patient.episodes),
function(x){ return x.active == true }
);
if(active_ids.length > 0){
if(active_ids.length){
return active_ids[0].id
}else{
return null;
Expand Down

1 comment on commit 65824bb

@davidmiller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, I don't think this is better :/
Unlike typos in the changelog this feels like a comment on a PR & discussion not a 'commit and merge thing'?

Please sign in to comment.