Merge eb023f7 into f2ac07c

openhealthcare · Aug 9, 2019 · 9f4a978 · 9f4a978
2 parents f2ac07c + eb023f7
commit 9f4a978
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,11 @@
 ### 0.17.0 (Major Release)
 
+#### Javascript API removals
+
+* Removes the function Episode.isDischarged() (This was rarely if ever used, and no longer an accurate represenation of dischargedness.)
+
+#### Miscelanious changes
+
 Bumps Flake8 version to 3.7.8 - new code will now be required to pass flake8 v3.7.8
 
 ### 0.16.0 (Major Release)

diff --git a/opal/static/js/opal/services/episode.js b/opal/static/js/opal/services/episode.js
@@ -239,14 +239,6 @@ recently changed it - refresh the page and try again');
                 return deferred.promise;
             },
 
-
-            //
-            // Predicate to determine whether this episode is discharged or not
-            //
-            isDischarged: function(){
-                return this.location[0].category == 'Discharged' ||
-                    (this.end && moment(this.end).isBefore(moment()));
-            }
         }; // Closes prototype
 
 

diff --git a/opal/static/js/test/episode.service.test.js b/opal/static/js/test/episode.service.test.js
@@ -319,12 +319,6 @@ describe('Episode', function() {
 
         });
 
-        describe('isDischarged()', function() {
-            it('should return true', function() {
-                expect(episode.isDischarged()).toEqual(true);
-            });
-        });
-
         describe('findByHospitalNumber()', function (){
             it('Should call the newPatient callback', function () {
                 var mock_new = jasmine.createSpy('Mock for new patient')