Seperate out write to file #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davidmiller
reviewed
May 19, 2017
opal/core/search/extract.py
Outdated
| renderer.write_to_file(full_file_name) | ||
| z.write(full_file_name, zip_relative_file_path(file_name)) | ||
| generate_files(os.path.join(target_dir, zipfolder), episodes, user) | ||
| file_names = generate_files(root_dir, episodes, user) |
There was a problem hiding this comment.
I'm not sure I understand why we're calling generate_files twice?
|
@davidmiller great call, done! |
davidmiller
reviewed
May 19, 2017
opal/core/search/extract.py
Outdated
| @@ -252,6 +252,42 @@ def __init__(self, model, episode_queryset, user, fields=None): | |||
| ) | |||
|
|
|||
|
|
|||
| def generate_files(root_dir, episodes, user): | |||
| """ Generate the files and return a tuple of absolute_file_name, file_name | |||
There was a problem hiding this comment.
Referring to the files makes me think we're in a spy drama ;)
Can we call these e.g. generate_full_extract_files for more spelling but less likelihood of renaming later ?
There was a problem hiding this comment.
do you say full extract because this will be in contrast to having inline extracts?
|
@davidmiller what do you think of generate_csv_files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.