352 our progressbar is a liar #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should now catch all places where we start a progressbar and handle failure cases with a cancellation of the progressbar. refs #352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that we fail to systematically ensure we're cleaning up after ourselves when we start a progressbar.
This results in the occasional ghost progress bar we've seen on occasion.
To reproduce this pre this PR you can for instance introduce a
raise ValueError()at the start ofopal.core.api.SubrecordViewSet.updateand attempt to edit a subrecord instance.It would be better if we had failure handlers for all of our things that start progress bars which end them.
closes #352