Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1573 pathway step save #1576

Closed
wants to merge 3 commits into from
Closed

1573 pathway step save #1576

wants to merge 3 commits into from

Conversation

fredkingham
Copy link
Contributor

the pre_save work exactly as you suggested.

Also previously there was a bug where if you defined the model on a step e.g.

class SomeStep(Step):
   model = MyModel

then SomeStep.model == None, so I have changed that as well.

There is a pull request ready for rfh when this is merged.

@davidmiller
Copy link
Member

Honestly I think the bug with declaring model = on the class would be better split out into it's own PR...

Would likely have merged earlier (at least at the start of these reviews!)

Can we try to remember what the use case for save_data is ?
I was struggling...

@fredkingham
Copy link
Contributor Author

This is two years old, and I think we've lost the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants