Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the blocks analytics anad javascripts in the base template, allo… #1580

Merged
merged 1 commit into from Sep 5, 2018

Conversation

fredkingham
Copy link
Contributor

@fredkingham fredkingham commented Aug 25, 2018

…wing parents to override

Hopefully not too controversial. Essentially allow overriding of our default analytics/javascripts template behaviour.

@davidmiller
Copy link
Member

I'm not sure I definitely see why you'd want to override these chunks (yet - sure there is a good reason !) ?

@fredkingham
Copy link
Contributor Author

So this all came out of the request to be able to print automagically print an area of the page.

Putting google analytics at the end of a page to get round our proxy problems is fine, but window.print has an implicit call to document.ready so will never complete if the analytics code is present.

We are appending a page onto the main page when we do the window.print. We therefore do not want to call the javascript twice (as its called on load). It also seems like a sensible thing to be able to override.

@davidmiller davidmiller merged commit 3f35a9c into v0.12.0 Sep 5, 2018
@davidmiller davidmiller deleted the javascirpt-and-analytics-blocks branch August 12, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants