Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1578 active in category #1626

Merged
merged 7 commits into from
Nov 2, 2018
Merged

1578 active in category #1626

merged 7 commits into from
Nov 2, 2018

Conversation

davidmiller
Copy link
Member

This is the final PR which closes #1578

Note that setting the value of .active in save without looking at the original value from the database could have resulted in this:

episode = Episode.objects.get(13)
episode.active = False
episode.save()
episode.active
# -> True

Instead we try to catch this and raise an exception to alert the user - the correct way to do this is to
have a category that agrees with whatever condition meant you thought you should set .active to False.

@fredkingham fredkingham merged commit b13c275 into v0.13.0 Nov 2, 2018
@davidmiller davidmiller deleted the 1578-active-in-category branch August 12, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants