removes the unused getNumberOfItems method from episode as this is ne…

changelog.md

@@ -5,6 +5,8 @@
 Removes the function Episode.isDischarged() (This was rarely if ever used,
 and no longer an accurate represenation of dischargedness.)
 
+Removes the Episode.getNumberOfItems method which is rarely used.
+
 Removes the methods PatientDetailCtrl.dischargeEpisode() and PatientListCtrl.dischargeEpisode()
 (However you're discharging episodes as of 0.17 it would be strongly unadvisable to do it this way.)
 

opal/static/js/opal/services/episode.js

@@ -60,10 +60,6 @@ angular.module('opal.services')
                 return this.demographics[0].first_name + ' ' + this.demographics[0].surname;
             },
 
-            getNumberOfItems: function(columnName) {
-                return this[columnName].length;
-            },
-
             // Getter function to return active episode tags.
             // Default implementation just hits tagging
             getTags: function(){

opal/static/js/test/episode.service.test.js

@@ -144,11 +144,6 @@ describe('Episode', function() {
         expect(episode.getFullName()).toEqual('John Smith');
     });
 
-    it('should know how many items it has in each column', function() {
-        expect(episode.getNumberOfItems('demographics')).toBe(1);
-        expect(episode.getNumberOfItems('diagnosis')).toBe(2);
-    });
-
     it('getTags() should get the current tags', function(){
         expect(episode.getTags()).toEqual(['mine', 'tropical']);
     });
@@ -192,9 +187,8 @@ describe('Episode', function() {
             episode,
             opalTestHelper.getRecordLoaderData().diagnosis
         );
-        expect(episode.getNumberOfItems('diagnosis')).toBe(2);
         episode.addItem(item);
-        expect(episode.getNumberOfItems('diagnosis')).toBe(3);
+        expect(_.last(episode.diagnosis).id).toBe(104)
     });
 
     it('should addItems() for items without an entry on episode', function() {