Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate edit item logic #440

Merged
merged 15 commits into from
Feb 24, 2016
Merged

Consolidate edit item logic #440

merged 15 commits into from
Feb 24, 2016

Conversation

fredkingham
Copy link
Contributor

sorry this is a bit massive,

wins

  • we now don't rely on $scope.episode to do any of our edit item logic
  • we consolidate the logic between episode list and episode detail
  • we cache user profile and options

you might not like

  • we bring in the cached profile straight to the record editor, which seemed like a nice decoupling but means we need to add a profile loader line in every test that uses episode
  • we remove the delete option in episode detail and you now delete in the modal which I think is a bit cleaner (if we like this we can remove the deletion code from the record editor)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling ef17fa1 on openhealthcare:consolidate-edit-item-logic into 1403e1b on openhealthcare:v0.6.0.

davidmiller added a commit that referenced this pull request Feb 24, 2016
@davidmiller davidmiller merged commit 2489719 into v0.6.0 Feb 24, 2016
@davidmiller davidmiller deleted the consolidate-edit-item-logic branch January 19, 2017 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants