Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeakReferenceCleaner now removed from REFERENCE_MAP on scheduleForClean() but breaks a test #68

Closed
peter-lawrey opened this issue Jun 5, 2018 · 3 comments
Closed

WeakReferenceCleaner now removed from REFERENCE_MAP on scheduleForClean() but breaks a test #68

peter-lawrey opened this issue Jun 5, 2018 · 3 comments
Assignees
@dpisklov

Comments

@peter-lawrey
Copy link
Member

peter-lawrey commented Jun 5, 2018 •
edited
Loading

The following enhancement to stop a map growing large under load and causing jitter, causes a test monitoring this map to blow up.

net.openhft.chronicle.queue.impl.single.AppenderFileHandleLeakTest#tailerShouldReleaseFileHandlesAsQueueRolls

    public void scheduleForClean() {
        SCHEDULED_CLEAN.add(this);
        REFERENCE_MAP.remove(this); // added to stop this map blowing up.
    }
peter-lawrey added a commit to OpenHFT/Chronicle-Queue that referenced this issue Jun 5, 2018
@peter-lawrey
@ignore test which looks at the internals of WeakReferenceCleaner Ope…
0787ee5 
…nHFT/Chronicle-Bytes#68
RobAustin pushed a commit to OpenHFT/Chronicle-Queue that referenced this issue Jun 21, 2018
fixed - OpenHFT/Chronicle-Bytes#68
5bd1659
@RobAustin RobAustin reopened this Jun 24, 2018
RobAustin pushed a commit to OpenHFT/Chronicle-Queue that referenced this issue Jun 24, 2018
OpenHFT/Chronicle-Bytes#68 added @ignore back in an reopend issue
bcf7fe5
@RobAustin
Copy link
Member

see
http://teamcity.higherfrequencytrading.com:8111/viewLog.html?buildId=269176&tab=buildResultsDiv&buildTypeId=OpenHFT_ChronicleQueue4_Snapshot

@RobAustin RobAustin reopened this Jun 29, 2018
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Bytes-1.16.17 (https://github.com/OpenHFT/Chronicle-Bytes/releases/chronicle-bytes-1.16.17), BOM-1.16.102 (https://github.com/OpenHFT/OpenHFT/releases/chronicle-bom-1.16.102)

@hft-team-city
Copy link
Collaborator

Released in Chronicle-Bytes-2.20.101, BOM-2.20.134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpisklov dpisklov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peter-lawrey @RobAustin @hft-team-city @dpisklov