error handling optimization

openhoat · Sep 25, 2016 · 30f3bec · 30f3bec
1 parent e87cc23
commit 30f3bec
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/lib/errors.js b/lib/errors.js
@@ -5,16 +5,13 @@ const _ = require('lodash');
 
 class OhmError extends Error {
   constructor(message, extra) {
-    super(message);
-    this.name = this.constructor.name;
     if (typeof extra === 'undefined' && typeof message === 'object') {
-      this.extra = message;
-      this.message = this.message && this.message !== '' ? this.message : JSON.stringify(this.extra);
-    } else {
-      this.message = this.message && this.message !== '' ? this.message : message;
-      this.extra = extra || this.extra;
+      extra = message;
+      message = null;
     }
-    this.message = this.message || '';
+    super(message);
+    this.name = this.constructor.name;
+    this.extra = extra;
   }
 
   toString() {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hw-redis-ohm",
-  "version": "0.5.10",
+  "version": "0.5.11",
   "description": "Redis Object Hash Mapping",
   "main": "lib/ohm.js",
   "scripts": {