Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FlashID is read incorrectly in a2_boot/main.c #322

Open
1 task done
janhoogerbrugge opened this issue Aug 29, 2023 · 4 comments
Open
1 task done

[BUG] FlashID is read incorrectly in a2_boot/main.c #322

janhoogerbrugge opened this issue Aug 29, 2023 · 4 comments
Assignees

Comments

@janhoogerbrugge
Copy link

Is there an existing core-v-mcu bug for this?

  • I have searched the existing bug issues

Bug Description

I see:

udma_flash_readid(lFlashID);

I assume that it should be:

udma_flash_readid((uint32_t *) &lFlashID);
@MikeOpenHWGroup
Copy link
Member

Hi @janhoogerbrugge, thanks for your interest in CORE-V-MCU. What file is this code in? Is it part of this repo or the CORE-V-MCU-CLI-TEST repo?

@janhoogerbrugge
Copy link
Author

@janhoogerbrugge
Copy link
Author

It should be: udma_flash_readid((uint32_t) &lFlashID);

@MikeOpenHWGroup
Copy link
Member

Hi @janhoogerbrugge, yes you are correct this is a bug and your fix is valid. As it turns out, you've highlighted a deeper issue in a2_boot in which it needs a flash to be present. This suites our application, but not the general case where a flash may not be present. We are investigating a proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants