Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android X support #417

Closed
SDemonUA opened this issue Oct 9, 2018 · 10 comments
Closed

Android X support #417

SDemonUA opened this issue Oct 9, 2018 · 10 comments

Comments

@SDemonUA
Copy link

SDemonUA commented Oct 9, 2018

Hi there,
Just migrated my app to AndroidX and now found type missmatch for methods that configure and work with custom tabs , i.e. 4th argument for AuthorizationService.performAuthorizationRequest().
Right now as I can see it builds and works fine, but can I do smth with that ?

@FizzyMobile
Copy link

Also I found out that Jetifier modifies ACTION_CUSTOM_TABS_CONNECTION value. Package manager doesn't recognize any application that can handle this action anymore.
The original value is android.support.customtabs.action.CustomTabsService and jetifiered is androidx.browser.customtabs.action.CustomTabsService.

@cwt-rami-citrom
Copy link

Is there any timeline for this fix?

CWT would like to offer a fix to this, but I see that there are already 6 open pull requests, from quite a while ago that have not been handled. Is this library still actively maintained?

@hnljp
Copy link
Contributor

hnljp commented Jan 2, 2019

Until it gets fixed, you can use: #423 (comment)

@hnljp
Copy link
Contributor

hnljp commented Jan 28, 2019

An updated version of the jetifier processor is on its way:
https://issuetracker.google.com/issues/119183822#comment7
Should fix the problem.

@hnljp
Copy link
Contributor

hnljp commented Feb 8, 2019

The jetifier processor has now been released.

@andreluizreis
Copy link

Please, is there any news about this issue? Why is taking so long to have an update?

@gary-archer
Copy link

As far as I'm aware AppAuth plays very nicely with androidx, though it may not have been officially certified. Code sample that I'm in the process of writing up is here: https://github.com/authguidance-examples/authguidance.mobilesample.android/blob/master/README.md

@alwa
Copy link

alwa commented Mar 18, 2021

I suggest that you consider making net.openid.appauth.AuthorizationManagementActivity extend androidx.appcompat.app.AppCompatActivity

@alwa
Copy link

alwa commented Mar 19, 2021

I will create a separate ticket for my request

@agologan
Copy link
Collaborator

agologan commented Apr 8, 2021

Library has been migrated to AndroidX in 0.8.0 with the exception of the activity mentioned by @alwa.

Closing this issue and will continue the discussion to that particular item in the PR.

@agologan agologan closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants