Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround androidx jetifier #438

Closed
wants to merge 3 commits into from
Closed

workaround androidx jetifier #438

wants to merge 3 commits into from

Conversation

auval
Copy link

@auval auval commented Jan 7, 2019

This workaround prevents androidx jetifier from replacing a hard-coded android.support string with its androidx counterpart that doesn't work.
It is backward compatible with pre-androidx projects, and makes AppAuth-Android work seamlessly with androidx projects.

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #438      +/-   ##
============================================
+ Coverage     83.71%   83.73%   +0.02%     
  Complexity      479      479              
============================================
  Files            42       42              
  Lines          2345     2348       +3     
  Branches        233      233              
============================================
+ Hits           1963     1966       +3     
  Misses          299      299              
  Partials         83       83
Impacted Files Coverage Δ Complexity Δ
...va/net/openid/appauth/browser/BrowserSelector.java 89.85% <100%> (+0.46%) 20 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8da5f5...77d4917. Read the comment docs.

@silentsudo
Copy link

This works like butter. Checked with following browser implementation

browserMatcher = new BrowserWhitelist(VersionedBrowserMatcher.CHROME_BROWSER, VersionedBrowserMatcher.CHROME_CUSTOM_TAB, VersionedBrowserMatcher.SAMSUNG_BROWSER, VersionedBrowserMatcher.SAMSUNG_CUSTOM_TAB, VersionedBrowserMatcher.FIREFOX_BROWSER, VersionedBrowserMatcher.FIREFOX_CUSTOM_TAB);

@jcloquell
Copy link

Thanks for this one! It would be really nice if it could get merged and released soon...

@nicklasl
Copy link

Also waiting for this to get merged!

@nguyenhuutinh
Copy link

waiting for this to get merged!

@hnljp
Copy link
Contributor

hnljp commented Jan 28, 2019

#417 (comment)
An updated version of the jetifier processor is on its way:
https://issuetracker.google.com/issues/119183822#comment7
Should fix the problem.

@raincoatforever
Copy link

The new jetifier beta does not seem to solve this issue. Could we please get this merged ?

@jcloquell
Copy link

The new jetifier beta does not seem to solve this issue. Could we please get this merged ?

Indeed, I tried it a couple of days ago and it didn't fix it :/

@WilliamDenniss
Copy link
Member

@auval do you have a CLA on file? If so, can you link to it?

@auval
Copy link
Author

auval commented Feb 24, 2019

@auval do you have a CLA on file? If so, can you link to it?
Working on it

@ouachman
Copy link

Hello everyone. What is the status on this issue?
I tried using the latest gradle plugin version and latest jetifier but I still can't make custom tabs working (all BrowserDescriptor return false to useCustomTab).
Is there a new release coming out soon? Otherwise is there a branch/build available with the fix that can be used via Gradle instead of the released version?
Thanks

@itsvssudheesh
Copy link

Waiting....⌛
Can someone please merge this PR

@fabiosanto
Copy link

waiting for this too...

@alosdev
Copy link

alosdev commented Apr 12, 2019

#444, therefore, no merge

alosdev added a commit to weshare-umigmbh/AppAuth-Android that referenced this pull request May 31, 2019
@auval
Copy link
Author

auval commented May 3, 2020

No longer a bug with androidx v 1.1.0

@auval auval closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet