-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workaround androidx jetifier #438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
============================================
+ Coverage 83.71% 83.73% +0.02%
Complexity 479 479
============================================
Files 42 42
Lines 2345 2348 +3
Branches 233 233
============================================
+ Hits 1963 1966 +3
Misses 299 299
Partials 83 83
Continue to review full report at Codecov.
|
This works like butter. Checked with following browser implementation
|
Thanks for this one! It would be really nice if it could get merged and released soon... |
Also waiting for this to get merged! |
waiting for this to get merged! |
#417 (comment) |
The new jetifier beta does not seem to solve this issue. Could we please get this merged ? |
Indeed, I tried it a couple of days ago and it didn't fix it :/ |
Hello everyone. What is the status on this issue? |
Waiting....⌛ |
waiting for this too... |
#444, therefore, no merge |
No longer a bug with androidx v 1.1.0 |
This workaround prevents androidx jetifier from replacing a hard-coded android.support string with its androidx counterpart that doesn't work.
It is backward compatible with pre-androidx projects, and makes AppAuth-Android work seamlessly with androidx projects.