Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds defines module to AppAuth.podspec #845

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mdmathias
Copy link
Collaborator

Fixes #844

@mdmathias mdmathias requested a review from yalkhder April 1, 2024 23:14
@mdmathias
Copy link
Collaborator Author

Waiting to merge based on result of Firebase/SpecStaging.

@mdmathias
Copy link
Collaborator Author

Merging since Firebase nightly tests look good with a similar gtm-session-fetcher change.

@mdmathias mdmathias merged commit eee20d3 into master Apr 2, 2024
10 checks passed
@mdmathias mdmathias deleted the mdmathias/defines_modules branch April 2, 2024 17:34
@vonovak
Copy link
Contributor

vonovak commented Apr 6, 2024

Hello and thanks for this fix 🙂

Would it be possible to have this released (and also the change in gtm) soon?

There are downstream packages building on top of this, such as RN Google sign in and maybe Flutter and others that are hitting #844 and having this published would make it easy to use the latest versions.
Thank you 🙂

@mdmathias
Copy link
Collaborator Author

@vonovak yes, the plan is to release this soon. I don't have a specific date to share because of privacy manifest work that I am responsible for elsewhere. I hope to get to this release in a week or two. Apologies for the delay.

I believe downstream clients can fix their issue -- by using use_frameworks! in their Podfile for example. I do think adding DEFINES_MODULE here is important since it means downstream clients do not need to make a fix on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants