Changed the default source and target java version to 1.7 :( #151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
============================================
- Coverage 72.31% 72.27% -0.04%
Complexity 483 483
============================================
Files 65 65
Lines 2669 2669
Branches 248 248
============================================
- Hits 1930 1929 -1
- Misses 668 670 +2
+ Partials 71 70 -1
Continue to review full report at Codecov.
|
| @@ -21,8 +21,8 @@ android { | |||
| } | |||
| } | |||
| compileOptions { | |||
| targetCompatibility 1.8 | |||
| sourceCompatibility 1.8 | |||
| targetCompatibility JavaVersion.VERSION_1_8 | |||
There was a problem hiding this comment.
Why keep 1_8 here? It may be easier for developers to understand the code if they are used to (so not Java 1.8)
There was a problem hiding this comment.
++ unless there's a good reason to do otherwise, we should be consistent with the Java version
There was a problem hiding this comment.
Given that is is was not part the public libraries I didn't see the need to remain consistent. In my mind the passwordlogin example was the "The latest and greatest practices" example, but there's no other motivation I can think of and you make a good point.
I will plan to migrate it in a follow up PR.
Fix for #145
Downgraded the version of java we compile against from 1.8 to 1.7.