Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additionalParameters when refreshing token using withFreshTokensPerformAction: #50

Closed
CraigLn opened this issue Oct 3, 2016 · 3 comments
Labels

Comments

@CraigLn
Copy link
Contributor

CraigLn commented Oct 3, 2016

Hello,

There doesn't seem to be a way to supply additional parameter when refreshing tokens using the recommended [OIDAuthState withFreshTokensPerformAction:] method.

Currently the manual way to achieve this is to obtain a request with [OIDAuthState tokenRefreshRequestWithAdditionalParameters:], perform the request with [OIDAuthorizationService performTokenRequest:callback:], and then update the auth state with [OIDAuthState updateWithTokenResponse:].

Doing this seems to go against the documentation to use [OIDAuthState withFreshTokensPerformAction:] to refresh tokens. I just wasn't sure if there was a reason to not include a method capable of performing this action in the more preferred way.

I've taken a stab at the functionality inside this PR: #49

@CraigLn
Copy link
Contributor Author

CraigLn commented Oct 11, 2016

Forgot to mention in the initial comment that this feature currently exists inside of Android, and is solved in the same manner.

@WilliamDenniss
Copy link
Member

Agree, let's fix this the same way as Android. Have commented in your PR.

@WilliamDenniss
Copy link
Member

Resolved by e6acfd9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants