[project @ Handle malformed HTTP headers in fetchers]

openid · Mar 13, 2008 · 2370ac1 · 2370ac1
1 parent a927e85
commit 2370ac1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/Auth/Yadis/ParanoidHTTPFetcher.php b/Auth/Yadis/ParanoidHTTPFetcher.php
@@ -125,8 +125,12 @@ function get($url, $extra_headers = null)
 
                 foreach ($headers as $header) {
                     if (preg_match("/:/", $header)) {
-                        list($name, $value) = explode(": ", $header, 2);
-                        $new_headers[$name] = $value;
+                        $parts = explode(": ", $header, 2);
+
+                        if (count($parts) == 2) {
+                            list($name, $value) = $parts;
+                            $new_headers[$name] = $value;
+                        }
                     }
                 }
 

diff --git a/Auth/Yadis/PlainHTTPFetcher.php b/Auth/Yadis/PlainHTTPFetcher.php
@@ -132,8 +132,12 @@ function get($url, $extra_headers = null)
 
         foreach ($headers as $header) {
             if (preg_match("/:/", $header)) {
-                list($name, $value) = explode(": ", $header, 2);
-                $new_headers[$name] = $value;
+                $parts = explode(": ", $header, 2);
+
+                if (count($parts) == 2) {
+                    list($name, $value) = $parts;
+                    $new_headers[$name] = $value;
+                }
             }
 
         }