PHP 5.3 support fix

[kost]

Fix for PHP 5.3 support as described here:

https://github.com/openid/php-openid/issues#issue/8

[meglio]

Hello. Why cannot we get this fix asap as it's very critical for new users like me with their projects hosted on php 5.3.

[meglio]

+1 - I cannot use it because of this problem.

[JonTheNiceGuy]

I'm not using this patch, but I'm using the trunk version on PHP 5.3.5 and am not encountering any issues that would require this patch.

What would I be seeing that would require me to patch this?

[everplays]

@JonTheNiceGuy

i think your error_reporting must be something like:
error_reporting= E_ALL & ~E_DEPRECATED

so you won't see "deprecated" error messages

[meglio]

It looks not reasonable to ask clients of the library to change error_reporting.
Any library must work with no errors when error_reporting is configured to maximum possible verbose mode.

[cash]

Here is the documentation on passing by reference: http://php.net/manual/en/language.references.pass.php

The tl;dr version is that passing scalar/arrays by reference is done in the function declaration, not in the function call (thus, the warning). There is no way removing the reference symbol could break anything.

I can check all the uses to make sure they are objects, but it would just be ensuring the library is not already broken (when it clearly is not).

Edit: Err - correction, actually passing by reference in the function call is deprecated so it should work...I'll check them.

[cash]

Okay - I checked them all and are convinced they are all objects and so are passed by reference.

[klebba]

Is this library still being maintained? Why would this fix take 1 year?

[marcoceppi]

This was fixed in #73