Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Vulnerable to man-in-the-middle attacks when not using pycurl #67

Closed
kilink opened this issue Aug 20, 2013 · 1 comment
Closed

Vulnerable to man-in-the-middle attacks when not using pycurl #67

kilink opened this issue Aug 20, 2013 · 1 comment

Comments

@kilink
Copy link

kilink commented Aug 20, 2013

HTTPS requests made by this package are vulnerable to MITM attacks when the user does not have pycurl installed, because urllib2 does not verify SSL certificates.

While openid.fetchers also has a fetcher for httplib2, unless explicitly registered it will not be chosen as the default fetcher.

At the very least I feel that this should be documented somewhere, but in my opinion the package should simply add a dependency on a library such as Requests that does SSL verification, and avoid the shenanigans of trying to import various other third-party libraries with fallbacks. If this is not feasible, then the httplib2 should at least be prioritized above urllib2, and perhaps a Requests fetcher should be added as the preferred fetcher.

@timcappalli
Copy link
Member

This repo is being archived. Closing issue.

@timcappalli timcappalli closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants