This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

read TIMEOUT from env first #109

Merged

tobiashm merged 1 commit into openid:master from MoonShining:timeout-env

Mar 28, 2018

MoonShining commented Dec 20, 2017

chineses government block specific http request, and the default TIMEOUT is 60 seconds
my rails app use unicorn, block a process 60s is unacceptable.

for now , I use some magic

OpenID::StandardFetcher.send :remove_const, 'TIMEOUT'
OpenID::StandardFetcher.const_set('TIMEOUT', 5)

it will be awesome if we read timeout from a environment variable RUBY_OPENID_FETCHER_TIMEOUTfirst, same way as we manage http_proxy


          read from env first

9c75899

tobiashm merged commit d0f9440 into openid:master

Contributor

tobiashm commented Mar 28, 2018

Thanks for the PR. Sorry for the late response.
I'll try to get a new version out soon.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request


          security/ruby-ruby-openid: update to 2.9.2

96b3866

Update ruby-ruby-openid package to version 2.9.2.


## 2.9.2

* Perform all checks before verifying endpoints.
  [#126](openid/ruby-openid#126)

## 2.9.1

* Updated CHANGELOG.md

## 2.9.0

* Remove deprecated `autorequire` from gemspec.
  [#123](openid/ruby-openid#123)
* Rescue from `Yadis::XRI::XRIHTTPError` on discovery.
  [#106](openid/ruby-openid#106)
* Avoid SSRF for claimed_id request.
  [#121](openid/ruby-openid#121)
* Updated documentation.
  [#115](openid/ruby-openid#115), [#116](openid/ruby-openid#116), [#117](openid/ruby-openid#117), [#118](openid/ruby-openid#118)
* Reduce warnings output in test runs.
  [#119](openid/ruby-openid#119)
* Drop deprecated option from gemspec.
  [#120](openid/ruby-openid#120)
* Remove circular require.
  [#113](openid/ruby-openid#113)
* Updated Travis CI config with Ruby 2.6
  [#114](openid/ruby-openid#114)
* Simplify Bundler require; remove need for extra `:require`.
  [#112](openid/ruby-openid#112)

## 2.8.0

* Fix `admin/mkassoc` script.
  See openid/ruby-openid#103
* Allow specifying timeout for `OpenID::StandardFetcher` in environment variables.
  See openid/ruby-openid#109
* Fixed some documentation.
  See openid/ruby-openid#111
* Fixed example server.
  See openid/ruby-openid#91
* Fixed tests.
  See openid/ruby-openid#86
* Misc. changes to the CI setup.
  See
  - openid/ruby-openid#110
  - openid/ruby-openid#108
  - openid/ruby-openid#107

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.