Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAI-29: Claim bundle evaluation websocket endpoint #2

Merged
merged 4 commits into from
Jan 19, 2021

Conversation

dborowiecki
Copy link
Contributor

Ticket: OAI-29

claim_ai/evaluation/bundle_evaluation.py Outdated Show resolved Hide resolved
claim_ai/test_response_bundle.py Show resolved Hide resolved
"code": "0"
}
]
"text": "accepted"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code 1 is for 'rejected'.

"code": "0"
}
]
"text": "rejected"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code 0 is for 'accepted'. This is based on the AI Model output.

@@ -211,45 +85,6 @@
]
}
],
"outcome": "valuated",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set as "complete".

@@ -211,45 +85,6 @@
]
}
],
"outcome": "valuated",
"patient": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave this.

"requestor": {
"reference": "HealthcareService/64D5D616-ED4C-4DAC-A87A-19A7CAF01259"
},
"status": "Not Selected",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory

@@ -8,28 +8,6 @@
"item": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let some comments after this, but is easier to follow based on the updated ClaimsResponse structure described in the specification: https://openimis.atlassian.net/wiki/spaces/OP/pages/1790345259/openIMIS-AI+-+6.+Specification#Build-FHIR-ClaimResponse

@dborowiecki
Copy link
Contributor Author

@dragos-dobre I updated response bundle to match the documentation, can you take a look?

@dragos-dobre dragos-dobre merged commit fd4ab83 into develop Jan 19, 2021
@dragos-dobre dragos-dobre deleted the feature/OAI-29 branch January 19, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants