OPL-6: Added Invoice graphQL #7
Conversation
invoice/gql/gql_types.py
Outdated
|
|
||
| "description": ["istartswith", "icontains", "iexact"], | ||
|
|
||
| "ledger_account": ["iexact"], |
There was a problem hiding this comment.
I think ["istartswith", "iexact"], will be better so you can type only the begining
invoice/gql/gql_types.py
Outdated
| "code_rcp": ["istartswith", "icontains", "iexact"], | ||
| "code_receipt": ["istartswith", "icontains", "iexact"], | ||
|
|
||
| "label": ["iexact"], |
There was a problem hiding this comment.
I think ["istartswith", "iexact"], will be better
invoice/gql/invoice/mutation.py
Outdated
| def _validate_mutation(cls, user, **data): | ||
| # TODO: What permissions should be used? | ||
| if type(user) is AnonymousUser or not user.id or not user.has_perms( | ||
| PolicyConfig.gql_mutation_create_policies_perms): |
There was a problem hiding this comment.
why this perm .gql_mutation_create_policies_perms ?
There was a problem hiding this comment.
Perms have been changed to the valid ones for this module.
|
|
||
|
|
||
| def get_default_currency(): | ||
| return InvoicePaymentConfig.default_currency_code | ||
|
|
||
|
|
||
| class Invoice(HistoryBusinessModel): | ||
| class Invoice(GenericInvoiceQuerysetMixin, HistoryBusinessModel): |
There was a problem hiding this comment.
as you add the mixin, can you change the recipient to thirdparty or you want to do another PR for that ?
There was a problem hiding this comment.
Can you elaborate, is the idea to create a mixin that would allow to use queries generically depending on whether invoice or bill is considered? if that's the case I think it'd be better to create separate PR, since this one is already quite big.
There was a problem hiding this comment.
@dborowiecki Please refer to this comment related to permissions.
invoice/apps.py
Outdated
| "gql_invoice_payment_delete_perms": ["155204"], | ||
| "gql_invoice_payment_refund_perms": ["155206"], | ||
|
|
||
| "gql_invoice_event_search_perms": ["155201"], |
There was a problem hiding this comment.
@dborowiecki Is this value correct? According to the wiki page - should be "155301" etc for 'EventInvoice'. https://openimis.atlassian.net/wiki/spaces/OP/pages/2858254346/Account+receivable+-+outbound+invoices
There was a problem hiding this comment.
Good catch, fixed
|
|
||
|
|
||
| def get_default_currency(): | ||
| return InvoicePaymentConfig.default_currency_code | ||
|
|
||
|
|
||
| class Invoice(HistoryBusinessModel): | ||
| class Invoice(GenericInvoiceQuerysetMixin, HistoryBusinessModel): |
TICKET: OPL-6