-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-1729: Error translation update. #43
base: develop
Are you sure you want to change the base?
Conversation
locale/en/LC_MESSAGES/django.po
Outdated
|
||
#: medical_pricelist/gql_mutations.py:221 | ||
#: medical_pricelist/gql_mutations.py:320 | ||
msgid "Unauthorized" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove one of them, you have two "unathorized" with different capitalization.
locale/en/LC_MESSAGES/django.po
Outdated
|
||
#: medical_pricelist/services.py:20 medical_pricelist/services.py:20 | ||
#, python-brace-format | ||
msgid "pricelist.mutation.failed_to_delete_{pricelist.model_prefix}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove curly braces in key.
@@ -48,12 +48,10 @@ def create_or_update_pricelist( | |||
if current_name != incoming_name: | |||
if isinstance(current_pricelist, ServicesPricelist): | |||
if check_unique_name_services_pricelist(incoming_name): | |||
raise ValidationError( | |||
_("mutation.service_name_duplicated")) | |||
raise ValidationError(_("mutation.service_name_duplicated")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not in scope of this ticket, but can you check this validation bug that you have mentioned? Run it with debugger if possible.
|
Ticket: https://openimis.atlassian.net/browse/OP-1729
Changes:
-Added translations
-Change import to from django.utils.translation import gettext as _