Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-25: add BenefitPlan to Django ORM #1

Merged
merged 38 commits into from May 22, 2023
Merged

CM-25: add BenefitPlan to Django ORM #1

merged 38 commits into from May 22, 2023

Conversation

jdolkowski
Copy link
Collaborator

@jdolkowski
CM-25: initial module structure
53c1ace
@jdolkowski
CM-25: add social_protection app config
830f529
@jdolkowski
CM-25: create BenefitPlan model
c62cb26
@jdolkowski
CM-25: add gql_mutations
8e423c6
@jdolkowski
CM-25: add mising fields to CreateBenefitPlanInputType
11b188f
@jdolkowski
CM-25: change code length
bcf03de
@jdolkowski
CM-25: create BenefitPlanGQLType
b133294
@jdolkowski
CM-25: add Query and Mutation in schema.py
7c74c05
@jdolkowski
CM-25: refactor schema.py
aeeedb7
@jdolkowski
CM-25: add benefit plan validations
70cca87
@jdolkowski
CM-25: add services.py
5f20a6c
@jdolkowski
CM-25: create initial test
0ef3f07
@jdolkowski
CM-25: fix typo
fb72ce9
@jdolkowski
CM-25: fix filter_fileds
5a48b3c
@jdolkowski
CM-25: add missing mutations
63a9235
@jdolkowski
CM-25 add migrations
59ebb59
@jdolkowski
CM-25: setup tests
0c2921a
@jdolkowski
CM-25: update module modules dependencies
74262c5
@jdolkowski
CM-25 update readme
ea40dae
@jdolkowski
CM-25: add benfit plan services
cd1cdd7
@jdolkowski
CM-25: route gql mutations through service
33f0283
@jdolkowski
CM-25: validate uniqueness of code and name
8fcf4cc
@jdolkowski
CM-25: update readme
76e86c9
@jdolkowski
CM-25: change get to filter
f7b8b48
dborowiecki
dborowiecki requested changes May 18, 2023
View reviewed changes
social_protection/models.py Outdated Show resolved Hide resolved
social_protection/models.py Outdated Show resolved Hide resolved
social_protection/schema.py Outdated Show resolved Hide resolved
social_protection/services.py Outdated Show resolved Hide resolved
social_protection/services.py Outdated Show resolved Hide resolved
social_protection/services.py Outdated Show resolved Hide resolved
social_protection/models.py Outdated Show resolved Hide resolved
social_protection/models.py Outdated Show resolved Hide resolved
sniedzielski
sniedzielski requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdolkowski Please refer to my comment.

social_protection/models.py Outdated Show resolved Hide resolved
dborowiecki
dborowiecki requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@dborowiecki dborowiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more comments

social_protection/validation.py Outdated Show resolved Hide resolved
social_protection/validation.py Outdated Show resolved Hide resolved
social_protection/validation.py Outdated Show resolved Hide resolved
social_protection/validation.py Outdated Show resolved Hide resolved
social_protection/validation.py Outdated Show resolved Hide resolved
social_protection/validation.py Outdated Show resolved Hide resolved
dborowiecki
dborowiecki requested changes May 22, 2023
View reviewed changes
social_protection/validation.py Outdated Show resolved Hide resolved
social_protection/validation.py Show resolved Hide resolved
dborowiecki
dborowiecki approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@dborowiecki dborowiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dborowiecki dborowiecki merged commit 16e5bef into develop May 22, 2023
2 checks passed
@dborowiecki dborowiecki deleted the feature/CM-25 branch May 22, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski requested changes

@dborowiecki dborowiecki dborowiecki approved these changes

@malinowskikam malinowskikam Awaiting requested review from malinowskikam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdolkowski @dborowiecki @malinowskikam @sniedzielski