CM-71: added support for applying queryset based on custom filters provided by frontend #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sniedzielski
changed the title
dborowiecki
requested changes
Jun 15, 2023
social_protection/custom_filters.py
Outdated
| """ | ||
| Apply custom filters to a queryset. | ||
|
|
||
| :param custom_filters: List of named tuples representing custom filters. |
There was a problem hiding this comment.
This information is already provided through in typehint, it's better to give some example of how this named tuple looks like.
social_protection/custom_filters.py
Outdated
| Apply custom filters to a queryset. | ||
|
|
||
| :param custom_filters: List of named tuples representing custom filters. | ||
| :type custom_filters: List[namedtuple] |
There was a problem hiding this comment.
I think this also is redundant, we have information about type in the hint.
social_protection/custom_filters.py
Outdated
| :param custom_filters: List of named tuples representing custom filters. | ||
| :type custom_filters: List[namedtuple] | ||
|
|
||
| :param query: The original queryset with filters. |
There was a problem hiding this comment.
Any specific type of QuerySet is required? Like Queryset[BenefitPlan] ?
There was a problem hiding this comment.
yes, sth like this. Mostly related to Queryset[Beneficiary] in that case.
|
@dborowiecki docsstring fixed |
dborowiecki
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ticket: https://openimis.atlassian.net/browse/CM-71