CM-27: BE - Add beneficiaries #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://openimis.atlassian.net/browse/CM-27
Based on the updated description https://openimis.atlassian.net/browse/CM-27 (update from last friday)
Note: I discussed with @malinowskikam about such points as:
We decide to use mutations even though ETL process therefore I decided to put here graphQL mutations too.
Moreover I wonder if should we use enum for 'status' etc or keep 'textfield'.
2nd Note: There is CI issue like on frontend level due to taking modules that aren't presented in openimis.json by default (individual module)