Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-854: passing props (district) to the component (HealthFacilityPicker) #32

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Nov 8, 2022

Part of OP-854.

I'm aware about the wrong branch name (should be feature/OP-854) and about a lack of ticket id in the first commit. It's my mistake.

@olewandowski1 olewandowski1 changed the title passing props (district) to the component (HealthFacilityPicker) OP-854: passing props (district) to the component (HealthFacilityPicker) Nov 8, 2022
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I left some comments, please refer to them.

In one of the comment I added proposition . You can treat this comment as a clue for improvement, but you don't have to do this in this scope.

src/components/UserMasterPanel.js Outdated Show resolved Hide resolved
src/components/UserMasterPanel.js Outdated Show resolved Hide resolved
src/components/UserMasterPanel.js Outdated Show resolved Hide resolved
src/components/UserMasterPanel.js Outdated Show resolved Hide resolved
@sniedzielski sniedzielski self-requested a review November 9, 2022 14:26
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM @olewandowski1 .

@delcroip delcroip merged commit 394bf11 into develop Nov 10, 2022
@delcroip delcroip deleted the feature/OSD-224 branch November 10, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants