OFS-287: Disable System checkbox #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delcroip
reviewed
May 7, 2021
src/components/RoleHeadPanel.js
Outdated
| @@ -58,7 +58,7 @@ class RoleHeadPanel extends FormPanel { | |||
| control={<Checkbox | |||
| checked={!!edited && !!edited.isSystem && edited.isSystem} | |||
| onChange={event => this.updateAttribute("isSystem", event.target.checked)} | |||
| disabled={!!isReadOnly} | |||
| disabled={!!edited && !!edited.id} | |||
There was a problem hiding this comment.
When creating a new Role we want to be able to set System to either true or false, correct? As I understand, this checkbox should be disabled only when editing/duplicating a Role.
There was a problem hiding this comment.
no, it should never be editable, it is for display only (system roles are created with database scripts)
rstencel
force-pushed
the
feature/OFS-287
branch
from
6dd294b
to
587ca33
Compare
delcroip
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openimis.atlassian.net/browse/OFS-287