ONI-106: User HF status information. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/HomePageContainer.js
Outdated
| @@ -53,6 +73,20 @@ const HomePageContainer = () => { | |||
| return null; | |||
| } | |||
|
|
|||
| let dateToCheck = new Date(userHealthFacility.contractEndDate); | |||
There was a problem hiding this comment.
Change let to const.
src/components/HomePageContainer.js
Outdated
| let dateToCheck = new Date(userHealthFacility.contractEndDate); | ||
| const timeDelta = getTimeDifferenceInDaysFromToday(dateToCheck); | ||
| const getHealthFacilityStatus = (timeDelta) => { | ||
| if(timeDelta>180){ |
There was a problem hiding this comment.
I will create a separate const for this '180' and '30'. Btw. it might be good idea to create overall const like:
const DAYS = { DAY: 1, WEEK: 7, MONTH: 30, YEAR: 360, };
If you won't create it like this, consider creating at least constants with more precise name.
src/components/HomePageContainer.js
Outdated
| if(timeDelta>180){ | ||
| return classes.healthFacilityLongTimeActive; | ||
| } | ||
| else if(timeDelta>30){ |
There was a problem hiding this comment.
Refer to the comment above.
olewandowski1
requested changes
Sep 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
marked this pull request as ready for review
dragos-dobre
added a commit
that referenced
this pull request
Oct 18, 2023
* ONI-106: User HF status information. (#14) * ONI-106: User HF status information. * ONI-106: HF status code review fixes. * ONI-106: HF status fixed if no HF assigned. (#16) * ONI-168: make a notice message larger (#18) * ONI-168: make a notice message larger * ONI-168: if user has no hf, show info about that instead of contract details * add-sonar-ci: add ci file (#19) Co-authored-by: Jan <j.dolkowski@soldevelo.com> --------- Co-authored-by: wzglinieckisoldevelo <98958634+wzglinieckisoldevelo@users.noreply.github.com> Co-authored-by: olewandowski1 <109145288+olewandowski1@users.noreply.github.com> Co-authored-by: Jan <jdolkowski@soldevelo.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://openimis.atlassian.net/browse/ONI-106
Required PR: openimis/openimis-fe-location_js#74
Changes: