Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTC-757: Clearing pagination state if entered the PoliciesPage #41

Merged
merged 2 commits into from Mar 22, 2023
Merged

OTC-757: Clearing pagination state if entered the PoliciesPage #41

merged 2 commits into from Mar 22, 2023

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Mar 22, 2023 •
edited

OTC-757

Changes:

  • Code refactor in PoliciesPage.
  • Clearing pagination state if entered the PoliciesPage.
  • Implementation of the logic responsible for going back from edit form and keeping the same page which was before.

@olewandowski1 olewandowski1 marked this pull request as ready for review March 22, 2023 13:47
sniedzielski
sniedzielski reviewed Mar 22, 2023
View reviewed changes
src/pages/PoliciesPage.js
historyPush(
this.props.modulesManager,
this.props.history,
"policy.route.policy",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be added as const value

sniedzielski
sniedzielski approved these changes Mar 22, 2023
View reviewed changes
Copy link

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment @olewandowski1 but anyway LGTM and we can merge solution.

@delcroip delcroip merged commit 30cf689 into develop Mar 22, 2023
@delcroip delcroip deleted the feature/OTC-757 branch March 22, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski approved these changes

@delcroip delcroip Awaiting requested review from delcroip

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olewandowski1 @sniedzielski @delcroip